8 Commits

Author SHA1 Message Date
FrigaT
1efa6764d1 поправлены стили v2
All checks were successful
CI / build-test (push) Successful in 45s
Release / pack-and-publish (release) Successful in 46s
2025-12-29 02:30:11 +03:00
FrigaT
edc4d5c087 Поправлены правила. Исправлен параметр формирования деталировки
All checks were successful
CI / build-test (push) Successful in 31s
Release / pack-and-publish (release) Successful in 34s
2025-12-29 02:19:30 +03:00
FrigaT
507c466b5d Доработаны правила
All checks were successful
CI / build-test (push) Successful in 35s
Release / pack-and-publish (release) Successful in 34s
2025-12-29 01:40:25 +03:00
FrigaT
7fb11364c4 Изменено формирование деталировки: зависимость от строк, а не от родителя
All checks were successful
CI / build-test (push) Successful in 38s
Release / pack-and-publish (release) Successful in 35s
2025-12-29 01:19:51 +03:00
FrigaT
19c2357c04 из html v1 убарана минификация (возвращено к стоку)
All checks were successful
CI / build-test (push) Successful in 35s
Release / pack-and-publish (release) Successful in 31s
2025-12-28 23:33:34 +03:00
FrigaT
3c4eda7f57 Доработан js2
All checks were successful
CI / build-test (push) Successful in 40s
Release / pack-and-publish (release) Successful in 47s
2025-12-28 23:26:51 +03:00
FrigaT
119d94b0e8 изменен стиль v2 html 2025-12-28 23:25:51 +03:00
FrigaT
bf6c0b9229 Доработан js 2025-12-28 20:10:37 +03:00
18 changed files with 1749 additions and 2791 deletions

View File

@@ -43,6 +43,7 @@ namespace SQLLinter.CLI
["UpdateWhere"] = Common.RuleViolationSeverity.Critical,
["UpperLower"] = Common.RuleViolationSeverity.Critical,
["SetVariable"] = Common.RuleViolationSeverity.Critical,
["CreateProcedureInDbo"] = Common.RuleViolationSeverity.Warning,
},
GenerateDetails = false,
};
@@ -62,30 +63,30 @@ namespace SQLLinter.CLI
Dictionary<string, Stream> files = new();
for (int i = 0; i < 2; i++)
for (int i = 0; i < 5; i++)
{
files[name + i + ".sql"] = reader.BaseStream;
}
linter.Run(files);
//diagramer.Run("test.sql", reader.BaseStream);
diagramer.Run("test.sql", reader.BaseStream);
}
//linter.Run(@"C:\Users\frost\Desktop\DISTR-2599\test.sql");
IReportFormatter formatter = new F.v3.HtmlReportFormatter();
var content = formatter.Format(rep.Violations, null);
var content = formatter.Format(rep.Violations, bpmn);
File.WriteAllText(@"C:\Users\frost\Downloads\Telegram Desktop\test3.html", content);
formatter = new F.v2.HtmlReportFormatter();
content = formatter.Format(rep.Violations, null);
content = formatter.Format(rep.Violations, bpmn);
File.WriteAllText(@"C:\Users\frost\Downloads\Telegram Desktop\test2.html", content);
formatter = new F.v1.HtmlReportFormatter();
content = formatter.Format(rep.Violations, null);
content = formatter.Format(rep.Violations, bpmn);
File.WriteAllText(@"C:\Users\frost\Downloads\Telegram Desktop\test1.html", content);
}
}

View File

@@ -83,8 +83,12 @@ public abstract class BaseRuleVisitor : TSqlFragmentVisitor, IRule
return string.Format(this.Text, param);
}
private TSqlFragment? FindContextBlock(TSqlFragment node)
{
if (_parents == null) return null;
return node;
var current = node;
while (current != null)
@@ -104,6 +108,14 @@ public abstract class BaseRuleVisitor : TSqlFragmentVisitor, IRule
case SchemaObjectFunctionTableReference:
return current;
// DML
case InsertStatement:
case UpdateStatement:
case DeleteStatement:
case MergeStatement:
return current;
// ---- Новые блоки для SqlDataTypeReference ----
// Определение столбца
@@ -131,7 +143,6 @@ public abstract class BaseRuleVisitor : TSqlFragmentVisitor, IRule
}
// Вспомогательные классы
public class ExtractedBlock
{
@@ -157,13 +168,15 @@ public abstract class BaseRuleVisitor : TSqlFragmentVisitor, IRule
protected ExtractedBlock? ExtractBlock(TSqlFragment? node, TSqlFragment errorNode)
{
if (node == null || node.ScriptTokenStream == null)
if (node == null || errorNode.ScriptTokenStream == null)
return null;
var endLine = errorNode.ScriptTokenStream.Where(t => t.Offset < node.StartOffset + node.FragmentLength).Max(t => t.Line) + 2;
// 1. Получаем токены для блока
var tokens = node.ScriptTokenStream
.Where(t => t.Line >= node.StartLine &&
t.Offset < node.StartOffset + node.FragmentLength)
var tokens = errorNode.ScriptTokenStream
.Where(t => t.Line >= node.StartLine - 2 &&
t.Line <= endLine)
.ToList();
if (tokens.Count == 0)

View File

@@ -13,5 +13,6 @@ public interface IRule
int DynamicSqlStartLine { get; set; }
IEnumerable<Violation> Analyze(TSqlFragment fragment);
void SetParents(Dictionary<TSqlFragment, TSqlFragment?>? parents);
}

View File

@@ -3,7 +3,6 @@ using SQLLinter.Common;
using SQLLinter.Core.Interfaces;
using SQLLinter.Infrastructure.Configuration.Overrides;
using SQLLinter.Infrastructure.Interfaces;
using SQLLinter.Infrastructure.Rules;
using SQLLinter.Infrastructure.Rules.RuleExceptions;
using SQLLinter.Infrastructure.Rules.RuleViolations;
using System.Data;
@@ -39,7 +38,8 @@ public class SqlRuleVisitor : IRuleVisitor
if (sqlFragment == null) return;
Dictionary<TSqlFragment, TSqlFragment?>? parentMap = generateDetails ? ParentMapBuilder.Build(sqlFragment) : null;
//Dictionary<TSqlFragment, TSqlFragment?>? parentMap = generateDetails ? ParentMapBuilder.Build(sqlFragment) : null;
Dictionary<TSqlFragment, TSqlFragment?>? parentMap = generateDetails ? new Dictionary<TSqlFragment, TSqlFragment?>() : null;
var ruleExceptions = ignoredRules as IRuleException[] ?? ignoredRules.ToArray();
if (errors.Any())

View File

@@ -143,6 +143,6 @@ public class HtmlReportFormatter : IReportFormatter
sb.AppendLine("</body>");
sb.AppendLine("</html>");
return HtmlMinifier.MinifyHtml(sb.ToString());
return sb.ToString();
}
}

View File

@@ -225,7 +225,7 @@ public class HtmlReportFormatter : IReportFormatter
var lineClass = "code-line";
if (isErrorLine)
{
lineClass += " error-line";
lineClass += $" {errorSeverity}-line";
}
sb.Append($"<div class=\"{lineClass}\">");

View File

@@ -12,7 +12,7 @@ public class AlterProcedureInDboRule : BaseRuleVisitor
{
if (node.ProcedureReference.Name.SchemaIdentifier?.Value.Equals("dbo", StringComparison.OrdinalIgnoreCase) == true)
{
AddViolation(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
AddViolation(node.ProcedureReference.Name.SchemaIdentifier, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
}
}
}

View File

@@ -17,14 +17,20 @@ public class ConditionalBeginEndRule : BaseRuleVisitor, IRule
public override void Visit(IfStatement node)
{
if (node.ThenStatement is not BeginEndBlockStatement)
if (node.ThenStatement != null && node.ThenStatement is not BeginEndBlockStatement && node.ThenStatement is not TryCatchStatement)
{
AddViolation(node);
if (node.ThenStatement.StartLine != node.StartLine || node.ScriptTokenStream.Where(t => t.Offset <= node.ThenStatement.StartOffset + node.ThenStatement.FragmentLength).Max(t => t.Line) != node.StartLine)
{
AddViolation(node.ThenStatement);
}
}
if (node.ElseStatement != null && node.ElseStatement is not BeginEndBlockStatement && node.ElseStatement is not IfStatement)
if (node.ElseStatement != null && node.ElseStatement is not BeginEndBlockStatement && node.ElseStatement is not TryCatchStatement && node.ElseStatement is not IfStatement)
{
AddViolation(Name, Text, GetLineNumber(node.ElseStatement), GetColumnNumber(node.ElseStatement));
if (node.ElseStatement.StartLine != node.StartLine || node.ScriptTokenStream.Where(t => t.Offset <= node.ElseStatement.StartOffset + node.ElseStatement.FragmentLength).Max(t => t.Line) != node.StartLine)
{
AddViolation(node.ElseStatement);
}
}
}

View File

@@ -12,14 +12,14 @@ public class CreateProcedureInDboRule : BaseRuleVisitor
{
if (node.ProcedureReference.Name.SchemaIdentifier?.Value.Equals("dbo", StringComparison.OrdinalIgnoreCase) == true)
{
AddViolation(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
AddViolation(node.ProcedureReference.Name.SchemaIdentifier, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
}
}
public override void Visit(CreateOrAlterProcedureStatement node)
{
if (node.ProcedureReference.Name.SchemaIdentifier?.Value.Equals("dbo", StringComparison.OrdinalIgnoreCase) == true)
{
AddViolation(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
AddViolation(node.ProcedureReference.Name.SchemaIdentifier, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
}
}
}

View File

@@ -20,6 +20,6 @@ public class DeleteWhereRule : BaseRuleVisitor, IRule
.Select(t => t.Text)
);
AddViolation(node, name);
AddViolation(node.Target, name);
}
}

View File

@@ -25,6 +25,6 @@ public class ExecuteAsOwnerRule : BaseRuleVisitor
}
}
AddViolation(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
AddViolation(node.ProcedureReference.Name, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
}
}

View File

@@ -20,9 +20,9 @@ public class HeaderCommentRule : BaseRuleVisitor
public override void Visit(CreateOrAlterTriggerStatement node) => private_visit(node, SQLHelpers.ObjectGetFullName(node.Name));
public override void Visit(CreateViewStatement node) => private_visit(node, "");
public override void Visit(CreateViewStatement node) => private_visit(node, SQLHelpers.ObjectGetFullName(node.SchemaObjectName));
public override void Visit(CreateOrAlterViewStatement node) => private_visit(node, "");
public override void Visit(CreateOrAlterViewStatement node) => private_visit(node, SQLHelpers.ObjectGetFullName(node.SchemaObjectName));
private void private_visit(TSqlFragment node, string name)
{
@@ -40,7 +40,23 @@ public class HeaderCommentRule : BaseRuleVisitor
prevToken.TokenType != TSqlTokenType.SingleLineComment && prevToken.TokenType != TSqlTokenType.MultilineComment
)
{
AddViolation(node, name);
if (node is ProcedureStatementBody proc)
{
AddViolation(proc.ProcedureReference.Name, name);
}
else if (node is ViewStatementBody view)
{
AddViolation(view.SchemaObjectName, name);
}
else if (node is TriggerStatementBody tr)
{
AddViolation(tr.Name, name);
}
else
{
AddViolation(node, name);
}
}
}
}

View File

@@ -11,7 +11,7 @@ public class InsertStarRule : BaseRuleVisitor
{
if (node.InsertSpecification.Columns.Count == 0) // INSERT без перечисления колонок
{
AddViolation(node);
AddViolation(node.InsertSpecification.Target);
}
}
}

View File

@@ -12,7 +12,7 @@ public class ProcedureLoggingRule : BaseRuleVisitor
public override void Visit(CreateOrAlterProcedureStatement node) => check(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
public override void Visit(AlterProcedureStatement node) => check(node, SQLHelpers.ObjectGetFullName(node.ProcedureReference.Name));
private void check(TSqlStatement node, string name)
private void check(ProcedureStatementBody node, string name)
{
var tokens = node.ScriptTokenStream;
@@ -35,7 +35,7 @@ public class ProcedureLoggingRule : BaseRuleVisitor
if (!hasDebugLog || !hasLabelFinish)
{
AddViolation(node, name);
AddViolation(node.ProcedureReference.Name, name);
}
}
}

View File

@@ -12,7 +12,7 @@ public class TempTableModificationRule : BaseRuleVisitor
{
if (node.UpdateSpecification.Target is NamedTableReference tbl && tbl.SchemaObject.BaseIdentifier.Value.StartsWith("#"))
{
AddViolation(node, SQLHelpers.ObjectGetFullName(tbl.SchemaObject));
AddViolation(node.UpdateSpecification.Target, SQLHelpers.ObjectGetFullName(tbl.SchemaObject));
}
}
@@ -20,7 +20,7 @@ public class TempTableModificationRule : BaseRuleVisitor
{
if (node.DeleteSpecification.Target is NamedTableReference tbl && tbl.SchemaObject.BaseIdentifier.Value.StartsWith("#"))
{
AddViolation(node, SQLHelpers.ObjectGetFullName(tbl.SchemaObject));
AddViolation(node.DeleteSpecification.Target, SQLHelpers.ObjectGetFullName(tbl.SchemaObject));
}
}
@@ -28,7 +28,7 @@ public class TempTableModificationRule : BaseRuleVisitor
{
if (node.SchemaObjectName.BaseIdentifier.Value.StartsWith("#"))
{
AddViolation(node, SQLHelpers.ObjectGetFullName(node.SchemaObjectName));
AddViolation(node.SchemaObjectName, SQLHelpers.ObjectGetFullName(node.SchemaObjectName));
}
}
}

View File

@@ -23,6 +23,6 @@ public class UpdateWhereRule : BaseRuleVisitor, IRule
.Select(t => t.Text)
);
AddViolation(node, name);
AddViolation(node.Target, name);
}
}