Поправлены правила. Исправлен параметр формирования деталировки
This commit is contained in:
@@ -39,7 +39,7 @@ public class SqlRuleVisitor : IRuleVisitor
|
||||
if (sqlFragment == null) return;
|
||||
|
||||
//Dictionary<TSqlFragment, TSqlFragment?>? parentMap = generateDetails ? ParentMapBuilder.Build(sqlFragment) : null;
|
||||
Dictionary<TSqlFragment, TSqlFragment?>? parentMap = new Dictionary<TSqlFragment, TSqlFragment?>();
|
||||
Dictionary<TSqlFragment, TSqlFragment?>? parentMap = generateDetails ? new Dictionary<TSqlFragment, TSqlFragment?>() : null;
|
||||
|
||||
var ruleExceptions = ignoredRules as IRuleException[] ?? ignoredRules.ToArray();
|
||||
if (errors.Any())
|
||||
|
||||
@@ -17,7 +17,7 @@ public class ConditionalBeginEndRule : BaseRuleVisitor, IRule
|
||||
|
||||
public override void Visit(IfStatement node)
|
||||
{
|
||||
if (node.ThenStatement != null && node.ThenStatement is not BeginEndBlockStatement)
|
||||
if (node.ThenStatement != null && node.ThenStatement is not BeginEndBlockStatement && node.ThenStatement is not TryCatchStatement)
|
||||
{
|
||||
if (node.ThenStatement.StartLine != node.StartLine || node.ScriptTokenStream.Where(t => t.Offset <= node.ThenStatement.StartOffset + node.ThenStatement.FragmentLength).Max(t => t.Line) != node.StartLine)
|
||||
{
|
||||
@@ -25,7 +25,7 @@ public class ConditionalBeginEndRule : BaseRuleVisitor, IRule
|
||||
}
|
||||
}
|
||||
|
||||
if (node.ElseStatement != null && node.ElseStatement is not BeginEndBlockStatement && node.ElseStatement is not IfStatement)
|
||||
if (node.ElseStatement != null && node.ElseStatement is not BeginEndBlockStatement && node.ElseStatement is not TryCatchStatement && node.ElseStatement is not IfStatement)
|
||||
{
|
||||
if (node.ElseStatement.StartLine != node.StartLine || node.ScriptTokenStream.Where(t => t.Offset <= node.ElseStatement.StartOffset + node.ElseStatement.FragmentLength).Max(t => t.Line) != node.StartLine)
|
||||
{
|
||||
|
||||
@@ -20,6 +20,6 @@ public class DeleteWhereRule : BaseRuleVisitor, IRule
|
||||
.Select(t => t.Text)
|
||||
);
|
||||
|
||||
AddViolation(node, name);
|
||||
AddViolation(node.Target, name);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user